spirv-val: Add static RayQuery/RayTracing value check#5567
Open
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Open
spirv-val: Add static RayQuery/RayTracing value check#5567spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
spencer-lunarg
force-pushed
the
spencer-lunarg-ray-query-2
branch
from
44f49d9 to
7846043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are various runtime checks for
OpRayQueryInitializeKHRandOpTraceRayKHR(exVUID-RuntimeSpirv-OpRayQueryInitializeKHR-06349andVUID-RuntimeSpirv-OpRayQueryInitializeKHR-06889) which I am adding to the Validation Layers.I realized there is no reason not to just do the check here in
spirv-valif the values are constant. (theEvalInt32IfConstis almost doing the same work the originalGetOperandTypeIdwas)I already had an issue where someone mixed the
tMinandtMaxvalues in their GLSL and there is no warning (granted it could warn in glslang, but probably other languages might not niether)